Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final retries for s3 timeouts #9861

Merged
merged 1 commit into from
Aug 28, 2019
Merged

Final retries for s3 timeouts #9861

merged 1 commit into from
Aug 28, 2019

Conversation

ryndaniels
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #7873

Release note for CHANGELOG:

BUG FIXES:
* resource/aws_s3_bucket: Final retries after timeouts creating, updating and updating replication configuration for s3 buckets
* resource/aws_s3_bucket_inventory: Final retries after timeous reading and putting bucket inventories
* resource/aws_s3_bucket_metric: Final retry after timeout putting bucket metric
* resource/aws_s3_bucket_notification: Final retry after timeout putting notification
* resource/aws_s3_bucket_policy: Final retry after timeout putting policy
* resource/aws_s3_bucket_public_access_block: Final retries after timeouts creating and reading blocks

Output from acceptance testing:

NOTE: TestAccAWSS3Bucket_Versioning failure is existing intermittent failure


$ make testacc TESTARGS="-run=TestAccAWSS3BucketInventory"      
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSS3BucketInventory -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSS3BucketInventory_basic
=== PAUSE TestAccAWSS3BucketInventory_basic
=== RUN   TestAccAWSS3BucketInventory_encryptWithSSES3
=== PAUSE TestAccAWSS3BucketInventory_encryptWithSSES3
=== RUN   TestAccAWSS3BucketInventory_encryptWithSSEKMS
=== PAUSE TestAccAWSS3BucketInventory_encryptWithSSEKMS
=== CONT  TestAccAWSS3BucketInventory_basic
=== CONT  TestAccAWSS3BucketInventory_encryptWithSSES3
=== CONT  TestAccAWSS3BucketInventory_encryptWithSSEKMS
--- PASS: TestAccAWSS3BucketInventory_encryptWithSSES3 (59.53s)
--- PASS: TestAccAWSS3BucketInventory_basic (60.97s)
--- PASS: TestAccAWSS3BucketInventory_encryptWithSSEKMS (85.78s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       86.898s

make testacc TESTARGS="-run=TestAccAWSS3BucketMetric"   
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSS3BucketMetric -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSS3BucketMetric_basic
=== PAUSE TestAccAWSS3BucketMetric_basic
=== RUN   TestAccAWSS3BucketMetric_WithEmptyFilter
=== PAUSE TestAccAWSS3BucketMetric_WithEmptyFilter
=== RUN   TestAccAWSS3BucketMetric_WithFilterPrefix
=== PAUSE TestAccAWSS3BucketMetric_WithFilterPrefix
=== RUN   TestAccAWSS3BucketMetric_WithFilterPrefixAndMultipleTags
=== PAUSE TestAccAWSS3BucketMetric_WithFilterPrefixAndMultipleTags
=== RUN   TestAccAWSS3BucketMetric_WithFilterPrefixAndSingleTag
=== PAUSE TestAccAWSS3BucketMetric_WithFilterPrefixAndSingleTag
=== RUN   TestAccAWSS3BucketMetric_WithFilterMultipleTags
=== PAUSE TestAccAWSS3BucketMetric_WithFilterMultipleTags
=== RUN   TestAccAWSS3BucketMetric_WithFilterSingleTag
=== PAUSE TestAccAWSS3BucketMetric_WithFilterSingleTag
=== CONT  TestAccAWSS3BucketMetric_basic
=== CONT  TestAccAWSS3BucketMetric_WithFilterPrefixAndSingleTag
=== CONT  TestAccAWSS3BucketMetric_WithEmptyFilter
=== CONT  TestAccAWSS3BucketMetric_WithFilterSingleTag
=== CONT  TestAccAWSS3BucketMetric_WithFilterPrefixAndMultipleTags
=== CONT  TestAccAWSS3BucketMetric_WithFilterPrefix
=== CONT  TestAccAWSS3BucketMetric_WithFilterMultipleTags
--- PASS: TestAccAWSS3BucketMetric_WithEmptyFilter (60.13s)
--- PASS: TestAccAWSS3BucketMetric_basic (61.80s)
--- PASS: TestAccAWSS3BucketMetric_WithFilterSingleTag (107.24s)
--- PASS: TestAccAWSS3BucketMetric_WithFilterPrefixAndSingleTag (107.98s)
--- PASS: TestAccAWSS3BucketMetric_WithFilterPrefixAndMultipleTags (108.43s)
--- PASS: TestAccAWSS3BucketMetric_WithFilterPrefix (109.35s)
--- PASS: TestAccAWSS3BucketMetric_WithFilterMultipleTags (109.73s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       110.901s

make testacc TESTARGS="-run=TestAccAWSS3BucketPolicy"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSS3BucketPolicy -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSS3BucketPolicy_basic
=== PAUSE TestAccAWSS3BucketPolicy_basic
=== RUN   TestAccAWSS3BucketPolicy_policyUpdate
=== PAUSE TestAccAWSS3BucketPolicy_policyUpdate
=== CONT  TestAccAWSS3BucketPolicy_basic
=== CONT  TestAccAWSS3BucketPolicy_policyUpdate
--- PASS: TestAccAWSS3BucketPolicy_basic (62.59s)
--- PASS: TestAccAWSS3BucketPolicy_policyUpdate (119.55s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       120.717s


--- PASS: TestAccAWSS3BucketObject_noNameNoKey (5.68s)
--- PASS: TestAccAWSS3BucketObject_content (18.28s)
--- PASS: TestAccAWSS3BucketInventory_basic (18.49s)
--- PASS: TestAccAWSS3BucketObject_source (19.57s)
--- PASS: TestAccAWSS3BucketMetric_WithEmptyFilter (19.83s)
--- PASS: TestAccAWSS3BucketObject_empty (19.66s)
--- PASS: TestAccAWSS3BucketMetric_basic (21.30s)
--- PASS: TestAccAWSS3BucketObject_etagEncryption (16.47s)
--- PASS: TestAccAWSS3BucketInventory_encryptWithSSES3 (22.51s)
--- PASS: TestAccAWSS3BucketNotification_Topic (22.84s)
--- PASS: TestAccAWSS3BucketMetric_WithFilterSingleTag (30.20s)
--- PASS: TestAccAWSS3BucketMetric_WithFilterPrefix (30.09s)
--- PASS: TestAccAWSS3BucketMetric_WithFilterPrefixAndMultipleTags (30.31s)
--- PASS: TestAccAWSS3BucketMetric_WithFilterMultipleTags (30.99s)
--- PASS: TestAccAWSS3BucketMetric_WithFilterPrefixAndSingleTag (33.75s)
--- PASS: TestAccAWSS3BucketObject_contentBase64 (15.98s)
--- PASS: TestAccAWSS3BucketNotification_update (36.04s)
--- PASS: TestAccAWSS3BucketObject_withContentCharacteristics (18.46s)
--- PASS: TestAccAWSS3BucketObject_sse (17.18s)
--- PASS: TestAccAWSS3BucketNotification_LambdaFunction (37.66s)
--- PASS: TestAccAWSS3BucketNotification_LambdaFunction_LambdaFunctionArn_Alias (38.22s)
--- PASS: TestAccAWSS3BucketInventory_encryptWithSSEKMS (40.64s)
--- PASS: TestAccAWSS3BucketObject_updates (27.34s)
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioning (29.34s)
--- PASS: TestAccAWSS3BucketPublicAccessBlock_basic (19.60s)
--- PASS: TestAccAWSS3BucketPublicAccessBlock_disappears (20.42s)
--- PASS: TestAccAWSS3BucketPolicy_basic (21.96s)
--- PASS: TestAccAWSS3Bucket_basic (16.19s)
--- PASS: TestAccAWSS3Bucket_importBasic (17.08s)
--- PASS: TestAccAWSS3Bucket_importWithPolicy (17.91s)
--- PASS: TestAccAWSS3BucketObject_kms (36.74s)
--- PASS: TestAccAWSS3Bucket_Bucket_EmptyString (16.19s)
--- PASS: TestAccAWSS3BucketObject_acl (39.49s)
--- PASS: TestAccAWSS3BucketObject_metadata (39.19s)
--- PASS: TestAccAWSS3BucketPolicy_policyUpdate (33.82s)
--- PASS: TestAccAWSS3Bucket_namePrefix (17.53s)
--- PASS: TestAccAWSS3Bucket_generatedName (17.51s)
--- PASS: TestAccAWSS3BucketObject_tagsLeadingSlash (51.08s)
--- PASS: TestAccAWSS3BucketObject_tags (53.86s)
--- PASS: TestAccAWSS3Bucket_enableDefaultEncryption_whenAES256IsUsed (15.95s)
--- PASS: TestAccAWSS3BucketPublicAccessBlock_BlockPublicAcls (42.86s)
--- PASS: TestAccAWSS3BucketPublicAccessBlock_IgnorePublicAcls (41.26s)
--- PASS: TestAccAWSS3Bucket_shouldFailNotFound (13.55s)
--- PASS: TestAccAWSS3BucketPublicAccessBlock_BlockPublicPolicy (44.61s)
--- PASS: TestAccAWSS3Bucket_RequestPayer (30.07s)
--- PASS: TestAccAWSS3BucketPublicAccessBlock_RestrictPublicBuckets (45.45s)
--- PASS: TestAccAWSS3Bucket_UpdateAcl (29.60s)
--- PASS: TestAccAWSS3Bucket_acceleration (32.71s)
--- PASS: TestAccAWSS3BucketObject_storageClass (62.65s)
--- PASS: TestAccAWSS3Bucket_WebsiteRoutingRules (28.08s)
--- PASS: TestAccAWSS3Bucket_disableDefaultEncryption_whenDefaultEncryptionIsEnabled (29.88s)
--- PASS: TestAccAWSS3Bucket_Policy (39.67s)
--- PASS: TestAccAWSS3Bucket_Cors_Delete (18.04s)
--- PASS: TestAccAWSS3Bucket_Cors_EmptyOrigin (18.82s)
--- PASS: TestAccAWSS3Bucket_enableDefaultEncryption_whenTypical (35.90s)
--- PASS: TestAccAWSS3Bucket_Website_Simple (40.46s)
--- PASS: TestAccAWSS3Bucket_WebsiteRedirect (39.88s)
--- PASS: TestAccAWSS3Bucket_Logging (20.60s)
--- FAIL: TestAccAWSS3Bucket_Versioning (33.15s)
--- PASS: TestAccAWSS3Bucket_Cors_Update (26.20s)
--- PASS: TestAccAWSS3Bucket_region (50.40s)
--- PASS: TestAccAWSS3Bucket_LifecycleExpireMarkerOnly (24.87s)
--- PASS: TestAccAWSS3Bucket_objectLock (20.96s)
--- PASS: TestAccAWSS3Bucket_LifecycleBasic (31.28s)
--- PASS: TestAccAWSS3Bucket_ReplicationWithoutStorageClass (57.36s)
--- PASS: TestAccAWSS3Bucket_ReplicationWithoutPrefix (56.27s)
--- PASS: TestAccAWSS3Bucket_ReplicationConfiguration_Rule_Destination_AccessControlTranslation (117.63s)
--- PASS: TestAccAWSS3Bucket_ReplicationSchemaV2 (159.30s)
--- PASS: TestAccAWSS3Bucket_Replication (178.64s)

make testacc TESTARGS="-run=TestAccAWSS3Bucket_ReplicationExpectVersioningValidationError"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSS3Bucket_ReplicationExpectVersioningValidationError -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSS3Bucket_ReplicationExpectVersioningValidationError
=== PAUSE TestAccAWSS3Bucket_ReplicationExpectVersioningValidationError
=== CONT  TestAccAWSS3Bucket_ReplicationExpectVersioningValidationError
--- PASS: TestAccAWSS3Bucket_ReplicationExpectVersioningValidationError (55.55s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       56.923s

make testacc TESTARGS="-run=TestAccAWSS3BucketNotification_Queue"    ==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSS3BucketNotification_Queue -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSS3BucketNotification_Queue
=== PAUSE TestAccAWSS3BucketNotification_Queue
=== CONT  TestAccAWSS3BucketNotification_Queue
--- PASS: TestAccAWSS3BucketNotification_Queue (84.26s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       85.344s

make testacc TESTARGS="-run=TestAccAWSS3BucketNotification_Topic_Multiple"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSS3BucketNotification_Topic_Multiple -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSS3BucketNotification_Topic_Multiple
=== PAUSE TestAccAWSS3BucketNotification_Topic_Multiple
=== CONT  TestAccAWSS3BucketNotification_Topic_Multiple
--- PASS: TestAccAWSS3BucketNotification_Topic_Multiple (74.34s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       75.330s

@ryndaniels ryndaniels requested a review from a team August 23, 2019 12:36
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/s3 Issues and PRs that pertain to the s3 service. labels Aug 23, 2019
@ryndaniels ryndaniels added the bug Addresses a defect in current functionality. label Aug 23, 2019
aeschright
aeschright reviewed Aug 27, 2019
View reviewed changes
Copy link
Contributor

@aeschright aeschright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of tests to run! All of the failures are known existing issues.

--- PASS: TestAccAWSS3BucketInventory_encryptWithSSES3 (22.26s)
--- PASS: TestAccAWSS3BucketInventory_basic (23.18s)
--- PASS: TestAccAWSS3BucketInventory_encryptWithSSEKMS (42.22s)
--- PASS: TestAccAWSS3BucketMetric_WithEmptyFilter (15.25s)
--- PASS: TestAccAWSS3BucketMetric_basic (17.61s)
--- PASS: TestAccAWSS3BucketMetric_WithFilterPrefix (27.17s)
--- PASS: TestAccAWSS3BucketMetric_WithFilterMultipleTags (27.31s)
--- PASS: TestAccAWSS3BucketMetric_WithFilterPrefixAndSingleTag (27.34s)
--- PASS: TestAccAWSS3BucketMetric_WithFilterPrefixAndMultipleTags (27.51s)
--- PASS: TestAccAWSS3BucketMetric_WithFilterSingleTag (27.75s)
--- PASS: TestAccAWSS3BucketPolicy_basic (17.71s)
--- PASS: TestAccAWSS3BucketPolicy_policyUpdate (27.67s)
--- PASS: TestAccAWSS3BucketObject_noNameNoKey (2.42s)
--- PASS: TestAccAWSS3BucketObject_etagEncryption (15.33s)
--- PASS: TestAccAWSS3BucketObject_empty (15.52s)
--- PASS: TestAccAWSS3BucketObject_source (15.74s)
--- PASS: TestAccAWSS3BucketObject_contentBase64 (15.87s)
--- PASS: TestAccAWSS3BucketObject_sse (15.94s)
--- PASS: TestAccAWSS3BucketObject_withContentCharacteristics (16.01s)
--- PASS: TestAccAWSS3BucketObject_content (16.37s)
--- PASS: TestAccAWSS3BucketObject_updates (25.33s)
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioning (25.57s)
--- PASS: TestAccAWSS3BucketObject_kms (34.88s)
--- PASS: TestAccAWSS3BucketObject_metadata (36.92s)
--- PASS: TestAccAWSS3BucketObject_tags (46.88s)
--- PASS: TestAccAWSS3BucketObject_storageClass (54.06s)
--- PASS: TestAccAWSS3Bucket_Cors_Delete (14.81s)
--- PASS: TestAccAWSS3Bucket_importBasic (17.48s)
--- PASS: TestAccAWSS3Bucket_Cors_EmptyOrigin (18.56s)
--- PASS: TestAccAWSS3Bucket_enableDefaultEncryption_whenAES256IsUsed (18.64s)
--- PASS: TestAccAWSS3Bucket_Cors_Update (26.26s)
--- PASS: TestAccAWSS3Bucket_namePrefix (14.09s)
--- PASS: TestAccAWSS3Bucket_Bucket_EmptyString (13.28s)
--- PASS: TestAccAWSS3Bucket_basic (13.57s)
--- PASS: TestAccAWSS3Bucket_enableDefaultEncryption_whenTypical (35.06s)
--- PASS: TestAccAWSS3Bucket_importWithPolicy (16.81s)
--- PASS: TestAccAWSS3Bucket_ReplicationExpectVersioningValidationError (38.50s)
--- PASS: TestAccAWSS3Bucket_generatedName (21.26s)        
--- PASS: TestAccAWSS3Bucket_UpdateAcl (30.99s)
--- PASS: TestAccAWSS3Bucket_ReplicationWithoutStorageClass (67.83s)
--- PASS: TestAccAWSS3Bucket_ReplicationWithoutPrefix (69.85s)
--- PASS: TestAccAWSS3Bucket_region (51.98s)
--- PASS: TestAccAWSS3BucketObject_acl (36.31s)
--- PASS: TestAccAWSS3BucketObject_tagsLeadingSlash (46.28s)
--- PASS: TestAccAWSS3Bucket_Logging (20.10s)
--- PASS: TestAccAWSS3Bucket_disableDefaultEncryption_whenDefaultEncryptionIsEnabled (26.34s)
--- PASS: TestAccAWSS3Bucket_LifecycleExpireMarkerOnly (27.54s)
--- PASS: TestAccAWSS3Bucket_WebsiteRoutingRules (30.01s)
--- PASS: TestAccAWSS3Bucket_Policy (36.05s)
--- PASS: TestAccAWSS3Bucket_ReplicationConfiguration_Rule_Destination_AccessControlTranslation (139.36s)
--- PASS: TestAccAWSS3Bucket_Website_Simple (37.69s)
--- PASS: TestAccAWSS3Bucket_ReplicationSchemaV2 (194.90s)
--- PASS: TestAccAWSS3Bucket_Replication (216.75s)
--- PASS: TestAccAWSS3Bucket_shouldFailNotFound (12.52s)
--- PASS: TestAccAWSS3Bucket_ReplicationWithoutPrefix (61.87s)
--- PASS: TestAccAWSS3Bucket_acceleration (28.95s)
--- PASS: TestAccAWSS3Bucket_WebsiteRedirect (36.58s)

--- FAIL: TestAccAWSS3Bucket_objectLock (21.16s)
    testing.go:568: Step 1 error: Check failed: Check 4/6 error: aws_s3_bucket.arbitrary: Attribute 'object_lock_configuration.0.rule.#' expected "1", got "0"
--- FAIL: TestAccAWSS3Bucket_Versioning (20.68s)
    testing.go:568: Step 1 error: Check failed: Check 2/2 error: bad error versioning status, found nil, expected: Enabled
--- FAIL: TestAccAWSS3Bucket_RequestPayer (21.61s)
    testing.go:568: Step 1 error: Check failed: Check 2/3 error: aws_s3_bucket.bucket: Attribute 'request_payer' expected "Requester", got "BucketOwner"
--- FAIL: TestAccAWSS3Bucket_LifecycleBasic (26.33s)
    testing.go:568: Step 0 error: Check failed: Check 2/42 error: aws_s3_bucket.bucket: Attribute 'lifecycle_rule.0.id' not found

@ryndaniels ryndaniels merged commit d8abdce into master Aug 28, 2019
@ryndaniels ryndaniels deleted the rfd-retry-s3 branch August 28, 2019 10:28
@nywilken nywilken added this to the v2.26.0 milestone Aug 29, 2019
@ghost
Copy link

ghost commented Aug 29, 2019

This has been released in version 2.26.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aeschright aeschright aeschright approved these changes

Assignees

@aeschright aeschright

Labels
bug Addresses a defect in current functionality. service/s3 Issues and PRs that pertain to the s3 service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v2.26.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ryndaniels @aeschright @nywilken